Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[visionOS] Fix Storage SDK build on Xcode 15 beta 6 #11667

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Aug 9, 2023

In Xcode 15 beta 6, #if os(iOS) no longer evaluates to true when building for visionOS.

Note: TARGET_OS_IOS continues to be defined so Objective-C code is unchanged.

#no-changelog -- Updated in #11666

@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseStorage-iOS-FirebaseStorage.framework

    Overall coverage changed from ? (77fa63d) to 0.00% (a517ccb) by ?.

    21 individual files with coverage change

    FilenameBase (77fa63d)Merge (a517ccb)Diff
    AsyncAwait.swift?0.00%?
    Result.swift?0.00%?
    Storage.swift?0.00%?
    StorageComponent.swift?0.00%?
    StorageDeleteTask.swift?0.00%?
    StorageDownloadTask.swift?0.00%?
    StorageError.swift?0.00%?
    StorageGetDownloadURLTask.swift?0.00%?
    StorageGetMetadataTask.swift?0.00%?
    StorageListResult.swift?0.00%?
    StorageListTask.swift?0.00%?
    StorageMetadata.swift?0.00%?
    StorageObservableTask.swift?0.00%?
    StoragePath.swift?0.00%?
    StorageReference.swift?0.00%?
    StorageTask.swift?0.00%?
    StorageTaskSnapshot.swift?0.00%?
    StorageTokenAuthorizer.swift?0.00%?
    StorageUpdateMetadataTask.swift?0.00%?
    StorageUploadTask.swift?0.00%?
    StorageUtils.swift?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Fa9pSL39Lc.html

@andrewheard andrewheard merged commit df56264 into master Aug 9, 2023
31 checks passed
@andrewheard andrewheard deleted the ah/xcode-15b6-storage branch August 9, 2023 18:31
@firebase firebase locked and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants